Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some units to declarations, minor test adjustments #1845

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Sep 27, 2024

Purpose of this PR

Type of change

  • Cleanup

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted the reporting in remind2 where it was needed
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters changed the title add some units, minor test adjustments add some units to declarations, minor test adjustments Sep 27, 2024
@orichters orichters merged commit 3e52d22 into remindmodel:develop Sep 27, 2024
2 checks passed
@orichters orichters deleted the units branch September 27, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants