Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename grindrock to weathering #1379

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

katarkow
Copy link
Contributor

Purpose of this PR

Renaming of technology rockgrind to weathering and updating the data revision version to the data with the renamed technology mrremind PR#407.

Type of change

  • Refactoring
  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date

@katarkow katarkow merged commit 64288b8 into remindmodel:develop Aug 16, 2023
1 check passed
@katarkow katarkow deleted the rename_grindrock branch August 16, 2023 08:20
Copy link
Contributor

@amerfort amerfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that! Looks good to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Weathering" refers to the full chain of the technology, i.e. not only grinding but also transportation and spreading of basalt, right? In the refactored CDR module and in our documentation we should be more explicit than just "grinding rock for enhanced weathering". But not necessary to change it now imo.

@katarkow katarkow mentioned this pull request Oct 18, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants