Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to coupled start scripts #1347

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Jul 10, 2023

Purpose of this PR

  • saving some improvements introduced in add multiplayer mode for coupled runs #1335
  • shift coupled model tests to auto mode to avoid that they fail on lack of priority runs
  • In case of fail tell user which command line arguments were passed to start_bundle_coupled.R
  • provide qos statistics after running start_bundle_coupled.R
  • ask before deleting any folder, and never delete on gamscompile
  • put plot_compare_iterations behind "try" such that it finishes the rest of the script in case of failure there
  • put Costs Without Incentives (million US$05/yr) as introduced here behind if to not fail on old reporting…
  • Use --mem=8000 option only if running on 1 CPU. I asked in the RSE channel a while ago whether adding it would harm, and it does:
slurmstepd: error: Job 26812886 exceeded memory limit (8344256 > 8192000), being killed
slurmstepd: error: Exceeded job memory limit
slurmstepd: error: *** JOB 26812886 ON cs-f14c02b10 CANCELLED AT 2023-06-16T00:37:19 ***

Type of change

  • Bug fix (mem=, plot_compare_iterations)
  • Refactoring

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • All automated model tests pass (FAIL 0 in the output of make test-coupled). See /p/tmp/oliverr/remind-smallfix/slurm-26964374.out

@orichters orichters merged commit ec714da into remindmodel:develop Jul 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants