324 #8
Open
324 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remedcu
added a commit
to safe-global/safe-deployments
that referenced
this pull request
Jul 9, 2024
This PR improves the review cycle for the `safe-deployment` by checking the new deployments when a new PR is created for a particular chain. This PR: - instead of an `ISSUE_TEMPLATE`, introduced a PR Template which will ask for the required data from the PR creator, and help run the CI script. - adds a CI review script, which succeeds if everything seems ok, else, it helps the PR creator to know what might be a problem with merging the PR in the CI logs. - updates the `github-review` script, which checks for edge cases when a chain ID with the highest number is added. - updates the test to accommodate the change in the JSON structure for the `codehash` (because `v.1.3.0` has multiple deployment types). - updated the JSON structure to include address and code hash within a single object with the deployment type as the key. - ZKSync support in CI mentioned in #662 (Ex: remedcu#8) Remaining TODO's: - There is a possibility that a user removes one of the deployment types (currently only applicable with `v1.3.0`) from the current list. This can't be detected with the current script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new chain
Please fill the following form:
Provide the Chain ID (Only 1 chain id per PR).
Provide RPC URL for the chain (should be able to query atleast 10 requests per minute for automatic PR check).
Relevant information:
Add any other relevant information like blockexplorer, any annotation...