Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix: 修复 windows watch 模式生命周期不生效的问题 #930

Merged
merged 6 commits into from
May 12, 2020

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented May 11, 2020

No description provided.

@vercel
Copy link

vercel bot commented May 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/remaxjs/remax/60sbvebvy
✅ Preview: https://remax-git-fix-life-events.remaxjs.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf22746:

Sandbox Source
hopeful-sunset-pskr1 Configuration

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #930 into master will increase coverage by 0.04%.
The diff coverage is 90.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   95.56%   95.60%   +0.04%     
==========================================
  Files         328      328              
  Lines        3473     3484      +11     
  Branches      501      500       -1     
==========================================
+ Hits         3319     3331      +12     
+ Misses        154      153       -1     
Impacted Files Coverage Δ
packages/remax-cli/src/build/webpack/config.web.ts 96.00% <ø> (-0.08%) ⬇️
packages/remax-cli/src/build/watch.ts 26.31% <25.00%> (+1.31%) ⬆️
...ages/remax-cli/src/build/webpack/plugins/Define.ts 98.14% <90.00%> (+0.07%) ⬆️
packages/remax-cli/src/build/babel/appEvent.ts 100.00% <100.00%> (ø)
packages/remax-cli/src/build/babel/pageEvent.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a706082...cf22746. Read the comment docs.

@Darmody
Copy link
Contributor Author

Darmody commented May 12, 2020

需要补充一个不 external runtime 的测试,验证生命周期收集问题

@vercel vercel bot temporarily deployed to Preview May 12, 2020 02:56 Inactive
@Darmody Darmody merged commit 29ca6e6 into master May 12, 2020
@Darmody Darmody deleted the fix-life-events branch May 12, 2020 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants