fix: 修复 watch 多执行一次的问题

remaxjs · May 11, 2020 · f3ac54b · f3ac54b
1 parent 2176c40
commit f3ac54b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/packages/remax-cli/src/build/watch.ts b/packages/remax-cli/src/build/watch.ts
@@ -4,13 +4,14 @@ import { Compiler } from 'webpack';
 import SingleEntryPlugin from 'webpack/lib/SingleEntryPlugin';
 import { getPages } from '../getEntries';
 
-let isFirstRunWatcher = true;
+let watchCounter = 0;
 
 export default function watch(options: Options, compiler: Compiler, watcher: any, addEntry = false) {
+  watchCounter += 1;
   // 监听额外的文件
   const pages = getPages(options);
   chokidar.watch([`${options.rootDir}/app.config.{js,ts}`]).on('change', () => {
-    if (isFirstRunWatcher) return;
+    if (watchCounter <= 1) return;
     if (addEntry) {
       const nextPages = getPages(options);
       nextPages.forEach(np => {
@@ -23,13 +24,9 @@ export default function watch(options: Options, compiler: Compiler, watcher: any
   });
 
   chokidar.watch([`${options.rootDir}/**/*.config.{js,ts}`]).on('all', () => {
-    if (isFirstRunWatcher) return;
+    if (watchCounter <= 1) return;
     watcher.invalidate();
   });
 
-  if (isFirstRunWatcher) {
-    isFirstRunWatcher = false;
-  }
-
   return watcher;
 }
diff --git a/packages/remax-cli/src/build/webpack/plugins/Define.ts b/packages/remax-cli/src/build/webpack/plugins/Define.ts
@@ -1,9 +1,11 @@
+import * as path from 'path';
 import { ReplaceSource } from 'webpack-sources';
 import { Compiler, compilation } from 'webpack';
 import { Options } from '@remax/types';
 import { appEvents, pageEvents, hostComponents } from '@remax/macro';
 import getModules from '../../utils/modules';
 import { getPages } from '../../../getEntries';
+import winPath from '../../../winPath';
 
 const PLUGIN_NAME = 'RemaxDefinePlugin';
 
@@ -58,10 +60,12 @@ export default class DefinePlugin {
       });
 
       // TODO: 应该有更好的获取 modules 的方式？
-      const modules = getModules(chunk);
+      const modules = getModules(chunk).filter(m =>
+        m.startsWith(winPath(path.join(this.remaxOptions.cwd, this.remaxOptions.rootDir)))
+      );
 
       events[page.name] = modules.reduce<string[]>((acc, cur) => {
-        return [...acc, ...(pageEvents.get(cur) || [])];
+        return [...acc, ...(pageEvents.get(winPath(cur)) || [])];
       }, []);
     });
 
@@ -75,10 +79,6 @@ export default class DefinePlugin {
       events = events.concat(Array.from(appEvents.get(key)!).sort());
     }
 
-    if (process.env.NODE_ENV === 'test') {
-      events = [];
-    }
-
     return JSON.stringify(events, null, 2);
   }