fix(web): 修复 web 下即使离开页面 onPageScroll 事件也会触发的问题 (#1232)

remaxjs · Aug 19, 2020 · 7ae649e · 7ae649e · vercel · Aug 19, 2020
1 parent 4623220
commit 7ae649e
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/packages/remax-runtime/src/createPageConfig.web.tsx b/packages/remax-runtime/src/createPageConfig.web.tsx
@@ -68,21 +68,23 @@ export default function createPageConfig(Page: React.ComponentType<any>, name: s
       page.callLifecycle(Lifecycle.show);
       page.callLifecycle(Lifecycle.ready);
 
-      this.handlePageScroll();
+      this.registerPageScroll();
     }
 
     componentWillUnmount() {
-      window.removeEventListener('scroll', this.scrollEvent);
+      this.unregisterPageScroll();
     }
 
     componentDidCache = () => {
       this.title = document.title;
       page.callLifecycle(Lifecycle.hide);
+      this.unregisterPageScroll();
     };
 
     componentDidRecover = () => {
       this.setTitle();
       page.callLifecycle(Lifecycle.show);
+      this.registerPageScroll();
     };
 
     setTitle = () => {
@@ -110,10 +112,14 @@ export default function createPageConfig(Page: React.ComponentType<any>, name: s
       page.callLifecycle(Lifecycle.pageScroll, event);
     };
 
-    handlePageScroll = () => {
+    registerPageScroll = () => {
       window.addEventListener('scroll', this.scrollEvent);
     };
 
+    unregisterPageScroll = () => {
+      window.removeEventListener('scroll', this.scrollEvent);
+    };
+
     handleRefresh = async () => {
       this.setState({
         refreshing: true,