Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test mutiple target PHP versions via docker and fixes some bugs #424

Merged
merged 10 commits into from
Feb 7, 2024

Conversation

sj-i
Copy link
Member

@sj-i sj-i commented Feb 7, 2024

Also fixes several bugs found on this way.
Because target VMs in docker containers are not children of the invoker process, we cannot simply attach them from the PHPUnit process.
So I have moved the PHPUnit process itself to a docker container too and given it CAP_SYS_PTRACE.

Maybe we should cache images for speeding up testing in CI.

@sj-i sj-i added bug Something isn't working enhancement New feature or request labels Feb 7, 2024
@coveralls
Copy link

coveralls commented Feb 7, 2024

Pull Request Test Coverage Report for Build 7815295514

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 45 of 60 (75.0%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.1%) to 86.214%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Lib/PhpInternals/Types/Zend/V74/ZendArray.php 1 16 6.25%
Files with Coverage Reduction New Missed Lines %
src/Lib/Elf/SymbolResolver/Elf64LinearScanSymbolResolver.php 1 85.71%
src/Lib/PhpInternals/Types/Zend/ZendExecuteData.php 1 93.78%
src/Lib/PhpProcessReader/PhpMemoryReader/MemoryLocation/ZendMmChunkMemoryLocation.php 4 71.43%
Totals Coverage Status
Change from base Build 7676075003: 2.1%
Covered Lines: 5372
Relevant Lines: 6231

💛 - Coveralls

@sj-i sj-i merged commit 6575bb9 into 0.11.x Feb 7, 2024
6 checks passed
@sj-i sj-i deleted the test-with-docker branch February 7, 2024 13:14
@sj-i sj-i added this to the 0.11.4 milestone Feb 14, 2024
@sj-i sj-i changed the title Test mutiple target PHP versions via docker Test mutiple target PHP versions via docker and fixes some bugs Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants