skip comments on converting phpspy compatible traces to the speedscop…

…e format and fix ordering of traces
reliforp · Oct 8, 2021 · a6c89d4 · a6c89d4
1 parent 01dd6f1
commit a6c89d4
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Command/Converter/SpeedscopeCommand.php b/src/Command/Converter/SpeedscopeCommand.php
@@ -67,7 +67,10 @@ private function parsePhpSpyCompatible(array $buffer): CallTrace
         $frames = [];
         foreach ($buffer as $line_buffer) {
             $result = explode(' ', $line_buffer);
-            [$_depth, $name, $file_line] = $result;
+            [$depth, $name, $file_line] = $result;
+            if ($depth === '#') { // comment
+                continue;
+            }
             [$file, $line] = explode(':', $file_line);
             $frames[] = new CallFrame(
                 '',
@@ -102,7 +105,7 @@ private function collectFrames(iterable $call_frames): array
                     }
                     $sampled_stack[] = $trace_map[$mapper_key];
             }
-            $sampled_stacks[] = $sampled_stack;
+            $sampled_stacks[] = \array_reverse($sampled_stack);
             $counter++;
         }
         return [