Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Relay v2.x #167

Merged
merged 4 commits into from
Feb 5, 2019
Merged

feat: Support Relay v2.x #167

merged 4 commits into from
Feb 5, 2019

Conversation

xdissent
Copy link
Contributor

@xdissent xdissent commented Feb 1, 2019

Closes #159

return query().name;
query = query();
if (query.name) return query.name;
if (query.params && query.params.name) return query.params.name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xdissent out of curiosity, what triggers this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean the query params, those are from the new relay-compiler. The getQueryName fn is only used in warnings IIRC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, i see... some cruft on my part. fixing it in #170

@taion taion changed the title Relay 2 feat: Support Relay v2.x Feb 5, 2019
@taion taion merged commit 97fb738 into relay-tools:next Feb 5, 2019
@taion taion mentioned this pull request Feb 5, 2019
@taion
Copy link
Member

taion commented Feb 5, 2019

released in v0.4.0-alpha.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants