Switch out non-ASCII quotes for ASCII versions. #1874
Conversation
|
Yeah, uh... Dan's kinda picky on that one :) I never managed to properly get them entered or displayed while working on the FAQ page, but Dan really seems to want that bit of typography, and he took the time to edit them in once I published my initial text. |
|
@gaearon Is this an issue? ASCII quotes are more accessible (namely when screenreaders vocalize the HTML character code as literal text instead of an ignored quote) and generally have less problems with tooling. |
|
Meh, whatever. I think ASCII quotes look super ugly but seems like nobody cares about this so I'm fine doing what most people do. :-)
Weird, I didn't known that. Do you mean that every single serious magazine on the web has this problem? I've never seen ASCII quotes on any serious website with text except tech docs but maybe I'm wrong. |
It's more of an issue when the tooling gets in the way and converts a quote symbol to an HTML entity or a mangled UTF-8 entity ("don’t"). |
|
Do we have tooling doing that? |
|
To be honest, I'm happy to stop caring about this, it's been an uphill battle for as long as I can remember. So I'm ok with this PR. |
|
Heh. That makes my job a bit easier, but I can understand the desire to make things like kinda nice. Thanks, Dan :) And sorry, Dan :( |
|
OK let's do it. 😄 |
In PR reduxjs#1874, a mass replacement of angled single quotes ’ with ASCII single quotes ' was approved. Since then, the docs have contained a mixture of angled and ASCII single quotes: ``` $ git log -S’ --since="Mon Aug 1 16:45:58 2016 -0400" --pretty=oneline | wc -l 17 ``` so it does not make sense to state a rule on them.
* Remove outdated rule on single quotes in docs In PR #1874, a mass replacement of angled single quotes ’ with ASCII single quotes ' was approved. Since then, the docs have contained a mixture of angled and ASCII single quotes: ``` $ git log -S’ --since="Mon Aug 1 16:45:58 2016 -0400" --pretty=oneline | wc -l 17 ``` so it does not make sense to state a rule on them. * Remove typographic stuff we don't use anyways.
* Remove outdated rule on single quotes in docs In PR reduxjs#1874, a mass replacement of angled single quotes ’ with ASCII single quotes ' was approved. Since then, the docs have contained a mixture of angled and ASCII single quotes: ``` $ git log -S’ --since="Mon Aug 1 16:45:58 2016 -0400" --pretty=oneline | wc -l 17 ``` so it does not make sense to state a rule on them. * Remove typographic stuff we don't use anyways. Former-commit-id: 99bbd43 Former-commit-id: 4d3298d
* Remove outdated rule on single quotes in docs In PR reduxjs#1874, a mass replacement of angled single quotes ’ with ASCII single quotes ' was approved. Since then, the docs have contained a mixture of angled and ASCII single quotes: ``` $ git log -S’ --since="Mon Aug 1 16:45:58 2016 -0400" --pretty=oneline | wc -l 17 ``` so it does not make sense to state a rule on them. * Remove typographic stuff we don't use anyways. Former-commit-id: 99bbd43 Former-commit-id: 4d3298d
I was going to just commit this on master, but that would probably bust every PR currently in play that touches the docs 😄
But the idea here is to use standard ASCII quotes everywhere. They smart quotes or angled quotes are causing some display issues in places (namely on GH Pages).