throw if getState, subscribe, or unsubscribe called while dispatching #1569

mwilc0x · 2016-04-02T18:45:43Z

This fixes #1568.

…tching

mwilc0x · 2016-04-02T19:12:35Z

Hey @gaearon, I added checks and updated tests. Let me know your thoughts, thanks!

gaearon · 2016-04-02T19:14:41Z

src/createStore.js

    var isSubscribed = true

    ensureCanMutateNextListeners()
    nextListeners.push(listener)

-    return function unsubscribe() {
+    return function unsubscribe() {     


Nit: empty spaces

gaearon · 2016-04-02T20:45:37Z

src/createStore.js

@@ -71,6 +71,14 @@ export default function createStore(reducer, initialState, enhancer) {
   * @returns {any} The current state tree of your application.
   */
  function getState() {
+    if (isDispatching) {
+      throw new Error(
+        'You may not call store.getState() while the reducer is executing.' +


These should have spaces right after the period, or you’ll end up with executing.The reducer

fixed with efd0d2e

mwilc0x · 2016-04-03T15:25:23Z

The subscribe and unsubscribe messages could probably be more helpful too.

I looked around, but didn't see anything specifically mentioning these scenarios in the documentation. Do you think this should be documented too?

Here is what I have for subscribe and unsubscribe:

// subscribe

'You may not call store.subscribe() while the reducer is executing. ' +
'If you would like to be notified after the store has been updated, subscribe from a ' +
'component and invoke store.getState() in the callback to access the latest state. ' +
'See http://redux.js.org/docs/api/Store.html#subscribe for more details.'

// unsubscribe

'You may not unsubscribe from a store listener while the reducer is executing. ' +
'See http://redux.js.org/docs/api/Store.html#subscribe for more details.'

gaearon · 2016-04-04T11:23:49Z

These sound good.

gaearon · 2016-08-07T12:22:13Z

Note: it’s a breaking change. Since we merged this to master, we can’t release patches now.

gaearon · 2016-08-07T12:23:04Z

I’m going to revert because we might need to release more patches.

I don’t currently have time to work on 4.x but if somebody wants to lead the effort I’m happy to discuss what should go there.

timdorr · 2016-08-07T12:24:19Z

I can extract the commit back out to next, if you want.

gaearon · 2016-08-07T12:24:52Z

👍

…#1569) * throw error if getState, subscribe, or unsubscribe called while dispatching * prevent throwing if not subscribed * update getState error message * fix space after period * update subscribe/unsubscribe error messages

timdorr · 2016-08-07T21:11:31Z

Done. bb9b86c

…#1569) * throw error if getState, subscribe, or unsubscribe called while dispatching * prevent throwing if not subscribed * update getState error message * fix space after period * update subscribe/unsubscribe error messages

…reduxjs#1569) * throw error if getState, subscribe, or unsubscribe called while dispatching * prevent throwing if not subscribed * update getState error message * fix space after period * update subscribe/unsubscribe error messages

phips28 · 2018-09-13T09:33:02Z

I came across this PR while researching the exception You may not unsubscribe from a store listener while the reducer is executing.
Its a React Native app.
I never use subscribe/unsubscribe in my own code, so maybe a library?
It only happens on Android releases, cant reproduce it in dev mode.
Root(native) is the class my index.android.js file, but there is no unsubscribe().
Can someone help me how to debug this?

Fatal Exception: com.facebook.react.common.JavascriptException: Error: You may not unsubscribe from a store listener while the reducer is executing. See https://redux.js.org/api-reference/store#subscribe(listener) for more details.

This error is located at:
    in Connect(n)
    in n
    in t
    in l
    in RCTView
    in Root(native)
    in RCTView
    in RCTView
    in t, stack:
<unknown>@320:3588
tryUnsubscribe@316:1319
componentWillUnmount@313:3148
ur@108:51027
fr@108:53185
si@108:64038
ui@108:61840
oi@108:61224
ri@108:60352
Ir@108:59332
enqueueSetState@108:31972
setState@14:1794
<unknown>@339:10124
<unknown>@475:990
value@475:946
b@677:2955
<unknown>@677:7728
<unknown>@475:990
value@475:946
d@489:710
i@489:1270
<unknown>@320:5006
<unknown>@1130:1359
v@320:4105
<unknown>@512:1380
<unknown>@1142:13183
<unknown>@1141:176
dispatch@320:6106
onSuccess@466:6655
<unknown>@462:826
_@126:151
<unknown>@126:878
<unknown>@29:1801
k@29:643
q@29:1007
callImmediates@29:3202
value@24:2904
<unknown>@24:1377
value@24:2621
value@24:1347
value@24:962

       at com.facebook.react.modules.core.ExceptionsManagerModule.showOrThrowError(ExceptionsManagerModule.java:54)
       at com.facebook.react.modules.core.ExceptionsManagerModule.reportFatalException(ExceptionsManagerModule.java:38)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
       at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:160)
       at com.facebook.react.bridge.queue.NativeRunnable.run(NativeRunnable.java)
       at android.os.Handler.handleCallback(Handler.java:739)
       at android.os.Handler.dispatchMessage(Handler.java:95)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:29)
       at android.os.Looper.loop(Looper.java:158)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:192)
       at java.lang.Thread.run(Thread.java:818)

mwilc0x · 2018-09-13T12:12:38Z

@phips28 it's hard to say without seeing the app's component code, but I think you might be doing some async action and then immediately unmounting a connected component before the async action has finished?

markerikson · 2018-09-13T16:23:54Z

Looking at the call stack, the unsubscribe is clearly coming from React-Redux's connect function, but this behavior "should" be impossible given how JS works. I see that it's an RN app, so there must be some complicating factor there somehow.

phips28 · 2018-09-14T13:14:45Z

I updated some libraries, maybe there was a breaking change somewhere. I added some more logging to locate the problem, but its difficult because I cannot reproduce it.
Will keep you posted.

phips28 · 2018-09-17T20:29:18Z

This is a un-debug-able bug crash 🙈

it only happens on android
only in release mode
but I can reproduce it, just press one button, but this button has no getState()

But the stacktrace doesnt help me lot.
Do you know how I can get more info to solve this issue?
Its really hard to debug when I always have to do a release build and this is minified, any idea how to create a non-minified bundle to see more info?

09-17 22:20:20.459 3714-3816/? E/ReactNativeJS: Error: You may not call store.getState() while the reducer is executing. The reducer has already received the state as an argument. Pass it down from the top reducer instead of reading it from the store.
    
    This error is located at:
        in Connect(t)
        in RCTView
        in n
        in RCTView
        in t
        in RCTView
        in RCTView
        in n
        in TouchableWithoutFeedback
        in RCTView
        in n
        in t
        in t
        in RCTView
        in n
        in t
        in t
        in t
        in RCTView
        in t
        in r
        in withCachedChildNavigation(r)
        in Unknown
        in n
        in n
        in RCTView
        in RCTView
        in n
        in Connect(n)
        in n
        in t
        in l
        in RCTView
        in Root(native)
        in RCTView
        in RCTView
        in t
    Error: You may not call store.getState() while the reducer is executing. The reducer has already received the state as an argument. Pass it down from the top reducer instead of reading it from the store.
    
    This error is located at:
        in Connect(t)
        in RCTView
        in n
        in RCTView
        in t
        in RCTView
        in RCTView
        in n
        in TouchableWithoutFeedback
        in RCTView
        in n
        in t
        in t
        in RCTView
        in n
        in t
        in t
        in t
        in RCTView
        in t
        in r
        in withCachedChildNavigation(r)
        in Unknown
        in n
        in n
        in RCTView
        in RCTView
        in n
        in Connect(n)
        in n
        in t
        in l
        in RCTView
        in Root(native)
        in RCTView
        in RCTView
        in t
    Error: You may not call store.getState() while the reducer is executing. The reducer has already received the state as an argument. Pass it down from the top reducer instead of reading it from the store.
    
    This error is located at:
        in Connect(t)
        in RCTView
        in n
        in Connect(n)
        in n
        in t
        in l
        in RCTView
        in Root(native)
        in RCTView
        in RCTView
        in t
09-17 22:20:20.479 3714-3816/? E/ReactNativeJS: Error: You may not call store.getState() while the reducer is executing. The reducer has already received the state as an argument. Pass it down from the top reducer instead of reading it from the store.
    
    This error is located at:
        in Connect(t)
        in RCTView
        in n
        in Connect(n)
        in n
        in t
        in l
        in RCTView
        in Root(native)
        in RCTView
        in RCTView
        in t
09-17 22:20:20.479 3714-3817/? E/unknown:ReactNative: Error: You may not call store.getState() while the reducer is executing. The reducer has already received the state as an argument. Pass it down from the top reducer instead of reading it from the store.
    
    This error is located at:
        in Connect(t)
        in RCTView
        in n
        in RCTView
        in t
        in RCTView
        in RCTView
        in n
        in TouchableWithoutFeedback
        in RCTView
        in n
        in t
        in t
        in RCTView
        in n
        in t
        in t
        in t
        in RCTView
        in t
        in r
        in withCachedChildNavigation(r)
        in Unknown
        in n
        in n
        in RCTView
        in RCTView
        in n
        in Connect(n)
        in n
        in t
        in l
        in RCTView
        in Root(native)
        in RCTView
        in RCTView
        in t, stack:
    y@320:2874
    run@313:4847
    componentWillReceiveProps@313:2959
    In@108:32600
    tr@108:45240
    Nr@108:56528
    Ur@108:56960
    ui@108:61804
    oi@108:61224
    ri@108:60352
    Ir@108:59332
    enqueueSetState@108:31972
    setState@14:1794
    <unknown>@339:6366
    <unknown>@475:990
    value@475:946
    b@677:3023
    <unknown>@677:7864
    <unknown>@475:990
    value@475:946
    d@489:710
    i@489:1270
    <unknown>@320:5006
    <unknown>@1130:1359
    v@320:4105
    <unknown>@512:1380
    <unknown>@1142:13183
    <unknown>@1141:176
    dispatch@320:6106
    onSuccess@466:6615
    <unknown>@462:649
    _@126:151
    <unknown>@126:878
    <unknown>@29:1801
    k@29:643
    q@29:1007
    callImmediates@29:3202
    value@24:2904
    <unknown>@24:1377
    value@24:2621
    value@24:1347
    value@24:962
09-17 22:20:20.489 3714-3817/? E/unknown:ReactNative: Error: You may not call store.getState() while the reducer is executing. The reducer has already received the state as an argument. Pass it down from the top reducer instead of reading it from the store.
    
    This error is located at:
        in Connect(t)
        in RCTView
        in n
        in RCTView
        in t
        in RCTView
        in RCTView
        in n
        in TouchableWithoutFeedback
        in RCTView
        in n
        in t
        in t
        in RCTView
        in n
        in t
        in t
        in t
        in RCTView
        in t
        in r
        in withCachedChildNavigation(r)
        in Unknown
        in n
        in n
        in RCTView
        in RCTView
        in n
        in Connect(n)
        in n
        in t
        in l
        in RCTView
        in Root(native)
        in RCTView
        in RCTView
        in t, stack:
    y@320:2874
    run@313:4847
    componentWillReceiveProps@313:2959
    In@108:32600
    tr@108:45240
    Nr@108:56528
    Ur@108:56960
    ui@108:61804
    oi@108:61224
    ri@108:60352
    Ir@108:59332
    enqueueSetState@108:31972
    setState@14:1794
    <unknown>@339:6366
    <unknown>@475:990
    value@475:946
    b@677:3023
    <unknown>@677:7864
    <unknown>@475:990
    value@475:946
    d@489:710
    i@489:1270
    <unknown>@320:5006
    <unknown>@1130:1359
    v@320:4105
    <unknown>@512:1380
    <unknown>@1142:13183
    <unknown>@1141:176
    dispatch@320:6106
    onSuccess@466:6615
    <unknown>@462:649
    _@126:151
    <unknown>@126:878
    <unknown>@29:1801
    k@29:643
    q@29:1007
    callImmediates@29:3202
    value@24:2904
    <unknown>@24:1377
    value@24:2621
    value@24:1347
    value@24:962

phips28 · 2018-09-18T11:35:28Z

I now disabled minification of the JS bundle and it seems to fix the problem.
I had no idea how to inject the extraArgs in gradle, so I edited this file directly:

PROJECT/node_modules/react-native/react.gradle

commandLine(*nodeExecutableAndArgs, cliPath, bundleCommand, "--platform", "android", "--dev", "${devEnabled}",
                            "--minify", "false", // <<<< fixes the connect() react-redux crash
                            "--reset-cache", "--entry-file", entryFile, "--bundle-output", jsBundleFile, "--assets-dest", resourcesDir, *extraArgs)

mwilc0x added 2 commits April 2, 2016 14:42

throw error if getState, subscribe, or unsubscribe called while dispa…

eb711ba

…tching

prevent throwing if not subscribed

7507eae

gaearon reviewed Apr 2, 2016
View reviewed changes

gaearon mentioned this pull request Apr 2, 2016

Forbid getState() and subscribe() while the reducer is being called #1568

Closed

update getState error message

f957b9f

gaearon reviewed Apr 2, 2016
View reviewed changes

fix space after period

efd0d2e

gaearon added this to the 4.0 milestone Apr 4, 2016

update subscribe/unsubscribe error messages

5065cab

timdorr merged commit cb5a00b into reduxjs:master Jul 19, 2016

mwilc0x deleted the prevent-reducer-calls branch July 19, 2016 18:15

timdorr mentioned this pull request Jul 25, 2016

avoid useless calls to listeners #1626

Closed

gaearon mentioned this pull request Aug 7, 2016

Revert "throw if getState, subscribe, or unsubscribe called while dispatching" #1882

Merged

SoundBot mentioned this pull request Sep 17, 2018

Migration guide for 4.0 #3138

Closed

markerikson mentioned this pull request Jun 7, 2019

Documentation/Changeling: Add ban of getState in reducers to the points #3442

Closed

snyk-bot mentioned this pull request Aug 30, 2019

[Snyk] Upgrade redux from 4.0.0 to 4.0.4 iliutastoica/react-slingshot#4

Open

snyk-bot mentioned this pull request Sep 23, 2019

[Snyk] Upgrade redux from 4.0.0 to 4.0.4 maxiplux/ReduxSimpleStarter#4

Merged

snyk-bot mentioned this pull request Oct 26, 2019

[Snyk] Upgrade redux from 3.7.2 to 4.0.4 ajesse11x/redux#5

Open

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade redux from 3.7.2 to 4.0.4 ajesse11x/redux#10

Open

snyk-bot mentioned this pull request Mar 14, 2020

[Snyk] Upgrade redux from 4.0.0 to 4.0.5 xalpinistx/ExpressProject#10

Merged

snyk-bot mentioned this pull request Mar 23, 2020

[Snyk] Upgrade redux from 4.0.0 to 4.0.5 viddo/atom-textual-velocity#516

Merged

snyk-bot mentioned this pull request Apr 26, 2020

[Snyk] Upgrade redux from 4.0.0 to 4.0.5 terrestris/gondolin-client#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

throw if getState, subscribe, or unsubscribe called while dispatching #1569

throw if getState, subscribe, or unsubscribe called while dispatching #1569

mwilc0x commented Apr 2, 2016

mwilc0x commented Apr 2, 2016

gaearon Apr 2, 2016

gaearon Apr 2, 2016

mwilc0x Apr 2, 2016

mwilc0x commented Apr 3, 2016

gaearon commented Apr 4, 2016

gaearon commented Aug 7, 2016

gaearon commented Aug 7, 2016

timdorr commented Aug 7, 2016

gaearon commented Aug 7, 2016

timdorr commented Aug 7, 2016

phips28 commented Sep 13, 2018

mwilc0x commented Sep 13, 2018

markerikson commented Sep 13, 2018

phips28 commented Sep 14, 2018 •

edited

Loading

phips28 commented Sep 17, 2018

phips28 commented Sep 18, 2018

throw if getState, subscribe, or unsubscribe called while dispatching #1569

throw if getState, subscribe, or unsubscribe called while dispatching #1569

Conversation

mwilc0x commented Apr 2, 2016

mwilc0x commented Apr 2, 2016

gaearon Apr 2, 2016

Choose a reason for hiding this comment

gaearon Apr 2, 2016

Choose a reason for hiding this comment

mwilc0x Apr 2, 2016

Choose a reason for hiding this comment

mwilc0x commented Apr 3, 2016

gaearon commented Apr 4, 2016

gaearon commented Aug 7, 2016

gaearon commented Aug 7, 2016

timdorr commented Aug 7, 2016

gaearon commented Aug 7, 2016

timdorr commented Aug 7, 2016

phips28 commented Sep 13, 2018

mwilc0x commented Sep 13, 2018

markerikson commented Sep 13, 2018

phips28 commented Sep 14, 2018 • edited Loading

phips28 commented Sep 17, 2018

phips28 commented Sep 18, 2018

phips28 commented Sep 14, 2018 •

edited

Loading