[v23.1.x] r/configuration_manager: add highest_known_offset checkpoint mutex #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, several background fibers spawned by consensus::disk_append could run configuration_manager::maybe_store_highest_known_offset in parallel. Because the storage_resources units were not released until we actually finished the kvstore write, every bg fiber launched during the kvstore debounce period will do a kvstore write on its own. This commit adds a flag that makes sure that we do only one checkpoint at a time. Fixes redpanda-data#9309 (cherry picked from commit 17df605)
(cherry picked from commit ec8f387)
mmaslankaprv
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #9827