Reduce the default for max_kafka_throttle_delay_ms
#9935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`max_kafka_throttle_delay_ms` default value changed to 30s to align with the default setting of `session.timeout.ms` in java client and in librdkafka which is 45s there. By setting the default max throttle delay lower than session timeout, it is possible to avoid heartbeat timeouts for librdkafka clients (librdkafka does not support KIP-219 as of now and therefore relies on broker doing throttling) with default configuration on both client and broker.
dotnwat
approved these changes
Apr 12, 2023
|
/backport v23.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_kafka_throttle_delay_msdefault value changed to 30s to align with the default setting ofsession.timeout.msin java client and in librdkafka which is 45s there. By setting the default max throttle delay lower than session timeout, it is possible to avoid heartbeat timeouts for librdkafka clients (librdkafka does not support KIP-219 as of now and therefore relies on broker doing throttling) with default configuration on both client and broker.Backports Required
Release Notes
Improvements