kafka: Usage manager bugfixes #9917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-repeat 2 skip-unit dt-repeat=50 tests/rptest/tests/usage_test.py::UsageTestCloudStorageMetrics.test_usage_manager_cloud_storage |
|
For those reviewing , this test was flaky because the admin.py class randomly chooses a node to query for usage_manager stats. The controller leader always had the correct results on it. The test has 30 seconds to complete so it has a moderate chance to grab the correct results from the follower leader. In the case it didn't it failed. |
|
/ci-repeat 2 skip-unit dt-repeat=50 tests/rptest/tests/usage_test.py |
graphcareful
changed the title
- Cloud storage metrics were only reported correctly when queried on the leader node. - This change ensures that the metric when queried is saved in memory in the health_montior on followers - Fixes: redpanda-data#9702
- Not calling `co_await` on mutex::get_units means no lock is actually held. - Fixes: redpanda-data#9647
graphcareful
force-pushed
the
fix-cloud-usage-test
branch
from
4ab12ae
to
9ded5ed
Compare
|
/ci-repeat 2 skip-unit dt-repeat=50 tests/rptest/tests/usage_test.py |
graphcareful
force-pushed
the
fix-cloud-usage-test
branch
from
579b69a
to
0879019
Compare
dotnwat
approved these changes
Apr 10, 2023
|
/ci-repeat 2 skip-unit dt-repeat=50 tests/rptest/tests/usage_test.py |
|
/backport v23.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where cloud storage metrics were only reported correctly when queried on the leader node.
Fixes a bug where multiple configuration updates would cause an inconsistency upon next reload of usage state
Backports Required
Release Notes
Bug Fixes