-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v23.1.x] Topic-aware leadership balancing #9901
Merged
piyushredpanda
merged 14 commits into
redpanda-data:v23.1.x
from
vbotbuildovich:backport-fixes-to-v23.1.x-340
Apr 11, 2023
Merged
[v23.1.x] Topic-aware leadership balancing #9901
piyushredpanda
merged 14 commits into
redpanda-data:v23.1.x
from
vbotbuildovich:backport-fixes-to-v23.1.x-340
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0c644d1)
Adds a couple of abstract classes that will be used to generalize constraints the leader balancer will be trying to maximize while balancing leadership. These clases are similar to the partition balancer's constraints. (cherry picked from commit 4a4a56a)
Defines a soft_constraint for determining error for how evenly distributed leadership is across shard in the cluster. Also moves the logic for a recommended reassignment for improving this error into a soft_constraint as well. (cherry picked from commit 24281e5)
(cherry picked from commit 93f1467)
(cherry picked from commit 26c12ec)
…ssignments (cherry picked from commit d8c7e83)
(cherry picked from commit 80a3a34)
…able (cherry picked from commit cdb6295)
This change allows one balance tick to schedule leader transfers up to that max in flight limit. This allows for the calculate state of the cluster to be reused for multiple transfer selections rather than being regenerated every selection. (cherry picked from commit 497d261)
(cherry picked from commit e3d6e69)
(cherry picked from commit c06824e)
(cherry picked from commit 7ef1c35)
(cherry picked from commit 8144487)
@ballard26 : The failure seems to be just #9774, we are trying to cut v23.1.7 by this Wednesday; just a default balancer change left here? |
dotnwat
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Failure seems to be #7418 now. Force-merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #7997