Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c/members_backend: check domain while decr removed replicas #9870

Merged
merged 1 commit into from
Apr 6, 2023
Merged

c/members_backend: check domain while decr removed replicas #9870

merged 1 commit into from
Apr 6, 2023

Conversation

ZeDRoman
Copy link
Contributor

@ZeDRoman ZeDRoman commented Apr 6, 2023 •
edited
Loading

in calculate_unevenness_error we calculate current replicas per node by domain. Previously we didn't check domain of replicas that are going to be removed so we decremented allocated_replicas incorreclty.

Now we add check that removing replica has same domain as we are counting now

Fixes #4371

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.1.x
  • v22.3.x
  • v22.2.x

Release Notes

Bug Fixes

  • Fix bug in calculate_unevenness_error when allocated_replicas on node goes below zero

@ZeDRoman
c/members_backend: check domain while decr removed replicas
4bdccb2 
in calculate_unevenness_error we calculate current replicas per node by
domain. Previously we didn't check domain of replicas that are going to
be removed so we decremented allocated_replicas incorreclty.

Now we add check that removing replica has same domain as we are
counting now
@ZeDRoman
Copy link
Contributor Author

ZeDRoman commented Apr 6, 2023

/ci-repeat 1
skip-units
dt-repeat=30
tests/rptest/tests/scaling_up_test.py::ScalingUpTest.test_adding_nodes_to_cluster

@ZeDRoman
Copy link
Contributor Author

ZeDRoman commented Apr 6, 2023

/ci-repeat 1
skip-units
dt-repeat=30
tests/rptest/tests/scaling_up_test.py::ScalingUpTest.test_adding_nodes_to_cluster*

@ZeDRoman ZeDRoman marked this pull request as ready for review April 6, 2023 12:16
@ZeDRoman
Copy link
Contributor Author

ZeDRoman commented Apr 6, 2023

/ci-repeat 1
skip-units
dt-repeat=30
tests/rptest/tests/scaling_up_test.py::ScalingUpTest.test_adding_nodes_to_cluster

@ZeDRoman ZeDRoman mentioned this pull request Apr 6, 2023
Merged
7 tasks
@mmaslankaprv mmaslankaprv self-requested a review April 6, 2023 15:43
@ZeDRoman ZeDRoman merged commit 60bd6df into redpanda-data:dev Apr 6, 2023
@mmaslankaprv mmaslankaprv mentioned this pull request Apr 26, 2023
Merged
7 tasks
mmaslankaprv added a commit that referenced this pull request Apr 27, 2023
@mmaslankaprv
Merge pull request #10300 from mmaslankaprv/v22.3.x
39e6472 
[v22.3.x] Backport of #10232 #9870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure in ScalingUpTest.test_adding_nodes_to_cluster
2 participants
@ZeDRoman @mmaslankaprv