[v22.3.x] Backport #8087 (net: improve logging of TLS & auth errors) #8118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the cases seen in the field on clusters that had ports exposed to the internet. Logging is worthwhile, logging at ERROR severity is not. (cherry picked from commit e61879a)
...for existing exception types that are authetnication errors. (cherry picked from commit edc2baa)
& with a message that distinguishes auth failures from general errors. This improves log hygiene on internet-facing clusters that will typically receive malformed probing connections from time to time. (cherry picked from commit 55344b5)
jcsp
requested review from
BenPope and
dotnwat
and removed request for
BenPope
6 tasks
dotnwat
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #8087
Backports Required
UX Changes
None
Release Notes
Improvements