-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix describe topics w/ docs and types #7877
Conversation
da1acf0
to
81ce31c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge improvements, left two small comments, nice work!
81ce31c
to
24792e4
Compare
24792e4
to
b80b818
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This test was failing because of poor STDOUT parsing that assumed a fixed number of lines. This commit removes those assumptions and uses regular expressions to parse STDOUT instead of string.split() Fixes redpanda-data#7851
b80b818
to
b11b7d8
Compare
CI failure is #7874 which should be fixed upstream now I'm restarting the K8s-operator and golinter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@NyaliaLui for the future: we control the wrappers around clients (e.g. KCL) so we can add the sort of parsing you are doing in this test to the client wrapper itself so that other users of the client don't accidentally recreate all the parsing later on.
Cover letter
This test was failing because of poor STDOUT parsing that assumed a fixed number of lines. This commit removes those assumptions and uses regular expressions to parse STDOUT instead of string.split()
Fixes #7851
Changes from force-push
81ce31c
:redpanda.datapolicy
from the property table and check it on its ownname in properties.keys()
can be rewritten asname in properties
Changes from force-push
24792e4
:redpanda.datapolicy
, check fordefault_config
is sufficientfor line in output
instead of an iterator so the StopIterator is automatically handledChanges from force-push
b80b818
andb11b7d8
:enumerate
to find the index of the table separator lineBackports Required
UX Changes
Release Notes