-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v22.3.x] Add an asychronous zstd stream compression class #7850
Merged
ballard26
merged 11 commits into
redpanda-data:v22.3.x
from
vbotbuildovich:backport-5116-5566-v22.3.x-214
Jan 5, 2023
Merged
[v22.3.x] Add an asychronous zstd stream compression class #7850
ballard26
merged 11 commits into
redpanda-data:v22.3.x
from
vbotbuildovich:backport-5116-5566-v22.3.x-214
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9716f66)
(cherry picked from commit e938dcb)
(cherry picked from commit af1a079)
…end` Adding additional scheduling points in `dispatch_send` to account for the newly futurized `as_scattered` results in a race condition where messages are sent out of order. As such the easiest solution is to call `as_scattered` outside of `dispatch_send` where adding a scheduling point won't result in this race condition. Then pass the result to `dispatch_send`. (cherry picked from commit c6ca7fd)
(cherry picked from commit ae838bb)
(cherry picked from commit 1cee0bf)
(cherry picked from commit 2a00125)
Results of performance testing vs the existing `stream_zstd` class are as follows: ``` test iterations median mad min max allocs tasks inst streaming_zstd_1mb.compress 6385 130.290us 1.513us 126.861us 137.173us 16.000 0.000 0.0 streaming_zstd_1mb.uncompress 4185 78.486us 2.100us 75.342us 80.586us 108.616 0.000 0.0 streaming_zstd_10mb.compress 653 1.118ms 24.680us 1.041ms 1.142ms 942.830 0.000 0.0 streaming_zstd_10mb.uncompress 429 844.631us 80.656us 760.340us 976.986us 2095.301 0.000 0.0 async_stream_zstd.1mb_compress 7616 100.022us 262.374ns 99.547us 100.598us 148.278 2.082 0.0 async_stream_zstd.1mb_uncompress 4804 73.661us 108.821ns 73.542us 73.819us 312.587 6.156 0.0 async_stream_zstd.10mb_compress 772 979.403us 1.092us 978.266us 985.029us 2176.762 56.239 0.0 async_stream_zstd.10mb_uncompress 490 728.405us 720.304ns 726.690us 731.632us 4089.282 109.756 0.0 ``` (cherry picked from commit bb0e700)
…itions (cherry picked from commit 12349cc)
(cherry picked from commit 2922bd5)
(cherry picked from commit 13223b6)
vbotbuildovich
requested review from
dotnwat,
bharathv,
jcsp,
twmb,
0x5d and
r-vasquez
December 19, 2022 20:43
LGTM but needs a clean test run |
Failed unit test is
The errors look similar to #6054 . But the fix for that issue should be in 22.3.x already |
/ci-repeat 5 debug |
The failure hasn't repeated after 6+ CI runs and appears unrelated to the changes. This should be ready to merge. |
jcsp
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #5565
Fixes #7849,