Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the balanced partition criteria in scaling up DTs #7768

Conversation

dlex
Copy link
Contributor

@dlex dlex commented Dec 14, 2022

The assessment whether partitions are balanced were done by comparing the number of partitions in each node with the average target ±20%. This way went broken with the introduction of partition balancing domains. The criteria is changed by this commit to make sure that the number of partitions across noded is levelled within a scope of each domain separately. Levelled means that min and max # of replicas differ by 1 at most.

Fixes #7418

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

  • none

Release Notes

  • none

The assessment whether partitions are balanced were done by comparing
the number of partitions in each node with the average target ±20%. This
way went broken with the introduction of partition balancing domains.
The criteria is changed by this commit to make sure that the number of
partitions across noded is levelled within a scope of each domain
separately. Levelled means that min and max # of replicas differ by 1
at most.
Re redpanda-data#7418
@dlex dlex changed the title ducky: change the balanced partition criteria Change the balanced partition criteria in scaling up DTs Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure (partitions_rebalanced times out) in ScalingUpTest.test_adding_nodes_to_cluster
2 participants