[v22.3.x] Fix cross-shard allocator manipulation #7415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Const member prevents copy and move assignment, but copy and move assignment seem to have reasonable semantics (the destination shard id is replaced by the source) and we need it for allocation_units oncore tracking. Issue redpanda-data#5558. (cherry picked from commit c64fdbb)
(cherry picked from commit 0565bf6)
Even though they ave movable, allocation_units objects must be destroyed on the same core the *original* allocation was made on, as they contain an embedded pointer back to the allocation state which lives on that core, since to do otherwise would be a cross-shard race-condition. Enforce this condition in debug mode using oncore checker. (cherry picked from commit e5dad45)
Return the allocation_units wrapped in a foreign pointer, since they need to be freed on the same core on which they were allocated. Fixes redpanda-data#5558. (cherry picked from commit 413cbe3)
Checks at the top of most functions to ensure that the core of the caller is the same as the home core of the state, only in debug builds. (cherry picked from commit 44c0dc7)
graphcareful
requested review from
andrewhsu and
travisdowns
and removed request for
dotnwat and
dlex
graphcareful
approved these changes
Nov 22, 2022
This was referenced Nov 22, 2022
|
/ci-repeat 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #7351
Fixes #7414,