Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Kafka SASL password as envar #7112

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

pvsune
Copy link
Contributor

@pvsune pvsune commented Nov 7, 2022

Cover letter

Instead of setting the Kafka SASL password in ConfigMap, set it as envar mounted from a Secret in the Deployment.

Backport Required

  • not a bug fix
  • issue does not exist in previous branches
  • papercut/not impactful enough to backport
  • v22.2.x
  • v22.1.x
  • v21.11.x

UX changes

None

Release notes

Improvements

  • Set Kafka SASL password as environment variable

@pvsune pvsune changed the title Pvsune/kafka sasl envar Set Kafka SASL password as envar Nov 7, 2022
@pvsune pvsune marked this pull request as ready for review November 7, 2022 05:41
@pvsune pvsune requested a review from a team as a code owner November 7, 2022 05:41
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wanted to say let's add tests but I see there's no deployment_test :)

@pvsune pvsune merged commit f4439b2 into redpanda-data:dev Nov 8, 2022
@pvsune pvsune deleted the pvsune/kafka-sasl-envar branch November 8, 2022 05:23
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Mar 10, 2023
…a-sasl-envar

Set Kafka SASL password as envar
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Mar 24, 2023
…fka-sasl-envar

Set Kafka SASL password as envar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants