-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: stress test client shutdown in the proxy client cache #6855
Merged
dotnwat
merged 1 commit into
redpanda-data:dev
from
NyaliaLui:basic-auth-client-stop-test
Oct 31, 2022
Merged
test: stress test client shutdown in the proxy client cache #6855
dotnwat
merged 1 commit into
redpanda-data:dev
from
NyaliaLui:basic-auth-client-stop-test
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyaliaLui
added
area/redpanda
area/pandaproxy
REST interface for Kafka API
area/tests
labels
Oct 20, 2022
NyaliaLui
commented
Oct 20, 2022
NyaliaLui
force-pushed
the
basic-auth-client-stop-test
branch
from
October 21, 2022 17:16
3780498
to
3ea2132
Compare
This is ready for review as well. |
/ci-repeat 5 |
6 tasks
BenPope
reviewed
Oct 25, 2022
dotnwat
requested changes
Oct 25, 2022
The kafka client stop() method is called whenever a client is evicted from the LRU cache. This commit adds a ducktape test that configures the cache to a max size of 1. The test stresses client stop() by issuing many rest requests with two unique users within a 30s loop. The idea is tigger eviction, and consequently client stop(), many times. Closes redpanda-data#6595 This commit also adds options to the RedpandaService for the client cache keep alive and client cache max size configs.
NyaliaLui
force-pushed
the
basic-auth-client-stop-test
branch
from
October 28, 2022 14:34
3ea2132
to
4067481
Compare
/ci-repeat 5 |
dotnwat
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Recent changes to the Pandaproxy involved creating a kafka client cache to support multiple authenticated connections. The client connection is closed when a client is evicted from the cache. Therefore, this PR adds a concurrency test that issues many requests to the proxy such that a client connection should be closed while other requests are still running.
Closes #6595
Changes from force-push
4067481
:Backport Required
UX changes
Release notes