Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allowedOrigins in RedpandaCloud as list of strings #6679

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

pvsune
Copy link
Contributor

@pvsune pvsune commented Oct 10, 2022

Cover letter

RedpandaCloud AllowedOrigins should be a list of strings, putting a CSV is only supported for environment variables.

Fixes https://github.com/redpanda-data/cloudv2/issues/2354
Slack discussion

Backport Required

  • not a bug fix
  • issue does not exist in previous branches
  • papercut/not impactful enough to backport
  • v22.2.x
  • v22.1.x
  • v21.11.x

UX changes

AllowedOrigins can be set as a list:

apiVersion: redpanda.vectorized.io/v1alpha1
kind: Console
metadata:
  name: test-console
  namespace: default
spec:
  clusterRef:
    name: rp-a029c4a
    namespace: rp-2-471-3743
  login:
    enabled: true
    redpandaCoud:
      enabled: true
      domain: vectorized-dev.us.auth0.com
      audience: dev.vectorized.cloud
      allowedOrigins:
      - http://localhost:3000
      - https://dev--redpanda-cloud.netlify.app/
  ...

Release notes

Improvements

  • RedpandaCloud AllowedOrigins can be set as a list

@pvsune pvsune marked this pull request as ready for review October 10, 2022 08:59
@pvsune pvsune requested a review from a team as a code owner October 10, 2022 08:59
- Test that console RedpandaCloud AllowedOrigins are equal to the generated ConfigMap
- Fix misspelled word in tests
@pvsune pvsune merged commit 57084cc into redpanda-data:dev Oct 11, 2022
@pvsune pvsune deleted the pvsune/allowed-origins-as-list branch October 11, 2022 07:33
@mmedenjak mmedenjak added the kind/enhance New feature or request label Oct 17, 2022
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Mar 10, 2023
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/k8s kind/enhance New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants