Fix shadow indexing mode selection #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLazar
force-pushed
the
fix-si-mode-selection
branch
from
dbb3989
to
c4e997e
Compare
abhijat
reviewed
Oct 7, 2022
| def test_shadow_indexing_mode(self, cloud_storage_enable_remote_read, | ||
| cloud_storage_enable_remote_write, | ||
| topic_remote_read, topic_remote_write): | ||
| to_bool = lambda x: True if x == "true" else False |
There was a problem hiding this comment.
nit: this could be simplified to:
Suggested change
| to_bool = lambda x: True if x == "true" else False | |
| to_bool = lambda x: x == "true" |
or maybe even compare directly:
read = ret["redpanda.remote.read"][0] == "true"
jcsp
reviewed
Oct 7, 2022
jcsp
reviewed
Oct 7, 2022
abhijat
reviewed
Oct 7, 2022
added 2 commits
October 7, 2022 12:57
Previously, topic level overrides of remote read/write were not honoured in some cases. For example, if remote write was enabled at the cluster level (cloud_storage_enable_remote_write=true) and disabled at the topic level (redpanda.remote.write=false), remote writes would still be performed. This is due to a bug in the logic which chooses the SI mode: if none of the topic level overrides are true, 'get_shadow_indexing_mode` returns a std::nullopt which causes the default value of the properties to be used. The default value is whatever the cluster level config is set to. This commit fixes the issue. Note that we may still return a std::nullopt if both remote read and write are unspecified at the topic level. This means that the topic will always follow the cluster level remote read/write configuration.
VladLazar
force-pushed
the
fix-si-mode-selection
branch
from
c4e997e
to
55fd2bf
Compare
|
Changes in force-push:
|
jcsp
approved these changes
Oct 7, 2022
mmedenjak
added
kind/bug
|
/backport v22.2.x |
|
/backport v22.1.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
Failed to run cherry-pick command. I executed the below command: |
|
/backport v22.2.x |
|
/backport v22.1.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
Failed to run cherry-pick command. I executed the below command: |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Previously, topic level overrides of remote read/write were not honoured
in some cases. For example, if remote write was enabled at the cluster
level (cloud_storage_enable_remote_write=true) and disabled at the topic
level (redpanda.remote.write=false), remote writes would still be
performed. This is due to a bug in the logic which chooses the SI mode:
if none of the topic level overrides are true,
'get_shadow_indexing_mode` returns a std::nullopt which causes the
default value of the properties to be used. The default value is
whatever the cluster level config is set to.
This PR fixes the issue and adds ducktape tests for the SI mode selection.
Backport Required
UX changes
Release notes
Bug Fixes