k8s: allow setting custom external ports for all listeners #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaferraro
changed the title
nicolaferraro
force-pushed
the
custom-ports
branch
from
f5d1740
to
9e60777
Compare
RafalKorepta
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This allows specifying a port for the external listener for admin API, Pandaproxy and Schema registry.
Since schema registry had a different configuration, I decided to add a flag for disabling auto-generation of the port, so that port is auto-generated by default (backward compatibility), but it's fixed when the
staticNodePortflag is true. In that case, the webhook will ensure that the port is in the [30000-32768] range.Release notes
Features