[v21.11.x] cloud_storage: check that we have serialized the whole manifest #6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that if the underlying buffer object throws (e.g. a bad_alloc exception), std::ostream swallows the exception and sets the "badbit". If we don't check it, this can lead to the serialized manifest being truncated and to corrupt manifests being uploaded to the cloud storage. To prevent that we check that std::ostream is in a good state after serializing manifests. More info: https://en.cppreference.com/w/cpp/io/ios_base/iostate Conflicts: src/v/cloud_storage/partition_manifest.cc src/v/cloud_storage/topic_manifest.cc src/v/cloud_storage/tx_range_manifest.cc
Lazin
approved these changes
Sep 22, 2022
mmedenjak
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from pull request: #6507