Raft: recovery throttle available units metric #6110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
approved these changes
Aug 19, 2022
ztlpn
approved these changes
Aug 19, 2022
| // TODO: Delete this metric after public is supported in scraping | ||
| // configurations | ||
| namespace sm = ss::metrics; | ||
| _internal_metrics.add_group( |
There was a problem hiding this comment.
nit: maybe we can have just a single function that takes a metrics endpoint as a parameter
There was a problem hiding this comment.
Didn't think about it
But I think that now it is easier to just delete this function without refactoring code later.
VladLazar
approved these changes
Aug 19, 2022
|
/backport v22.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Add recovery throttle metric that shows current available units in recovery semaphore.
Fixes partially: #4817
Backport Required
Release notes
Features