cloud_storage: Fix transactions e2e test #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log frequent message on trace instead of debug.
Extend prefix logger header with segment base/max offsets.
Currently, tx-manifests are downloaded every time. Because of that we will make a request to S3 when the remote_segment is materialized. Even if transactions are not used we will still have to make a request to get NoSuchKey response. To avoid this this commit adds logic that seralizes the manifest to SI cache.
mmedenjak
added
kind/bug
ztlpn
previously approved these changes
Aug 13, 2022
dotnwat
reviewed
Aug 13, 2022
| @@ -216,6 +219,7 @@ def done(): | |||
| producer.produce(self.topic) | |||
| except ck.KafkaException as err: | |||
| self.logger.warn(f"producer error: {err}") | |||
| time.sleep(10) | |||
There was a problem hiding this comment.
Use short timeout if kafka producer returned an error. Add exception for
BadLogLines.
This commit message is describing the literal introduction of the sleep, not why the sleep is being added. Can you add the why to the commit message?
Use short timeout if kafka producer returned an error. This is needed to guarantee that the previous transaction was aborted. The added delay is longer than the transaction's timeout. Add exception for BadLogLines.
Lazin
force-pushed
the
fix/transactions-e2e-test
branch
from
1eee35a
to
7cdc775
Compare
ztlpn
approved these changes
Aug 15, 2022
|
\backport v22.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Fix test_restore_with_aborted_tx test failure on CI.
Use
transactions.timeout.msin kafka producer and add delay before reconnect.Fix segment hydration logic
remote_segment. Currently, the tx-manifest is never saved to SI cache. This PR fixes this so the materialization of transactional metadata could be done from cache instead of S3.Backport Required
UX changes
none
Release notes
Improvements