Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk/k8s: enable gofumpt as default go formatter #4665

Merged

Conversation

r-vasquez
Copy link
Contributor

Cover letter

Backport for #4664 this is important because in dev branch this formatter change will be done and we want to avoid backport failing due to formatting mismatch

Fixes #4664

Release notes

@r-vasquez r-vasquez requested review from twmb, 0x5d, LenaAn and a team as code owners May 10, 2022 23:12
@r-vasquez r-vasquez requested review from andrewhsu and removed request for a team May 10, 2022 23:12
@twmb
Copy link
Contributor

twmb commented May 10, 2022

This is merged in dev, merging into v22.1.x so that backport PRs do not run into weird formatting differences.

@twmb twmb merged commit f1c0c46 into redpanda-data:v22.1.x May 10, 2022
@andrewhsu andrewhsu added this to the v22.1.3 milestone May 11, 2022
@r-vasquez r-vasquez deleted the backport-v22.1.x-enable-gofumpt branch June 22, 2022 20:02
RafalKorepta pushed a commit to RafalKorepta/redpanda that referenced this pull request Oct 30, 2022
The gofumpt is used now.

REF: redpanda-data#4665
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Mar 10, 2023
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Mar 24, 2023
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Apr 12, 2023
The gofumpt is used now.

REF: redpanda-data#4665
(cherry picked from commit 1c150d3)
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Apr 12, 2023
The gofumpt is used now.

REF: redpanda-data#4665
(cherry picked from commit 1c150d3)
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Apr 13, 2023
The gofumpt is used now.

REF: redpanda-data#4665
(cherry picked from commit 1c150d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants