-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redpanda: remove _redpanda_enabled=false mode #4324
Conversation
110044c
to
6beebd9
Compare
CI failure was known issue #4887 |
src/v/redpanda/application.cc
Outdated
// This includes loading from local bootstrap file or legacy | ||
// config file on first-start or upgrade cases. | ||
_config_preload = cluster::config_manager::preload(config).get0(); | ||
auto node_config_errors = config::node().load(config); | ||
for (const auto& i : node_config_errors) { | ||
vlog( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace update in subsequent commit, because all the indentation
jumps around & otherwise it's not obvious what I'm doing here.
wow you're not kidding
Redpanda is always enabled.
Whitespace update in subsequent commit, because all the indentation jumps around & otherwise it's not obvious what I'm doing here.
6beebd9
to
6ef1f84
Compare
@@ -438,8 +438,6 @@ void application::hydrate_config(const po::variables_map& cfg) { | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace update in subsequent commit, because all the indentation
jumps around & otherwise it's not obvious what I'm doing here.
🙏
from what i can tell this PR |
Yep. As far as I can tell, there aren't even any doc changes, because the old standalone modes were undocumented. |
Cover letter
This was the code path for running schema registry
outside of a redpanda cluster. Once we always
run schema registry inside a redpanda cluster,
this is no longer necessary.
Fixes https://github.com/redpanda-data/core-internal/issues/35
Release notes
Improvements