[v23.3.x] archival: skip spillover retention if not collectable #23361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFLICT: - updated test for GTest Compact-only topics should never apply retention. This wasn't the case for the spillover region in tiered storage. Note, for the STM region, we do correctly no-op when trying to apply retention for compacted topics. (cherry picked from commit 26df815)
andrwng
requested review from
dotnwat and
nvartolomei
and removed request for
dotnwat
dotnwat
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preemptive backport of #23358
CONFLICT:
Compact-only topics should never apply retention. This wasn't the case for the spillover region in tiered storage.
Note, for the STM region, we do correctly no-op when trying to apply retention for compacted topics.
(cherry picked from commit 26df815)
Backports Required
Release Notes
Bug Fixes