[v23.3.x] k/group_manager: return not_coordinator quickly in tx operations #23187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group_manager::attached_partition::catchup_lock can get blocked for extended periods of time. For example in the following scenario: 1. consumer_offsets partition leader gets isolated 2. some group operation acquires a read lock and tries to replicate a batch to the consumer_offsets partition. This operation hangs for an indefinite period of time. 3. the consumer_offsets leader steps down 4. group state cleanup gets triggered, tries to acquire a write lock, hangs until (2) finishes Meanwhile, clients trying to perform any tx group operations will get a coordinator_load_in_progress errors and blindly retry, without even trying to find the real coordinator. Check for leadership without the read lock first to prevent that (this is basically a "double-check" pattern as we have to check the second time under the lock.) (cherry picked from commit 440ed2c)
ztlpn
force-pushed
the
backport-pr-23176-v23.3.x-856
branch
from
b11dbe3
to
cbd4cdc
Compare
|
Test failure: https://redpandadata.atlassian.net/browse/CORE-2758 |
ztlpn
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23176