Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.2.x] rpk: fix --no-profile and add cloud checks for rpk security user commands. #23066

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[v24.2.x] rpk: fix --no-profile and add cloud checks for rpk security user commands. #23066

merged 2 commits into from
Aug 27, 2024

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #23047

@r-vasquez @vbotbuildovich
rpk: fix --no-profile for SSO
6508ebc 
We were not checking for `--no-profile` in certain
scenarios.

Moved the logic so we exit early if the user dont
want a profile

(cherry picked from commit 572ad19)
@r-vasquez @vbotbuildovich
rpk: add Admin API command check for rpk security users
1cae3d7 
These commands can't be run in Cloud Clusters,
except for Serverless.

(cherry picked from commit fe47685)
@vbotbuildovich vbotbuildovich added this to the v24.2.x-next milestone Aug 26, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Aug 26, 2024
@r-vasquez r-vasquez merged commit db3dbbf into redpanda-data:v24.2.x Aug 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vasquez r-vasquez r-vasquez approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.2.x-next
Development

Successfully merging this pull request may close these issues.
2 participants
@vbotbuildovich @r-vasquez