[v23.3.x] CORE-6824 Schema Registry/Proto: add 5 missing checks #22860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically we reed to enforce the presence of _nested_ message types. Previously we only checked at file scope. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 1072f02)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit bfc715b)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 689ebad)
(cherry picked from commit 9c1670a)
(cherry picked from commit d2e710a)
pgellert
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22798