cloud_storage: add error_outcome::operation_not_supported
#22339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `abs_error_code::operation_not_supported_on_directory` for future handling of errors that arise when a `Delete Blob` request is made on a directory.
Adds a value to the `cloud_storage::error_outcome` enum for handling cases where the response to a request made had some flavor of `OperationNotSupported` code. This will be used immediately to handle a case for the `abs_client` where `Delete Blob` requests made on directories results in a `OperationNotSupportedOnDirectory` response.
andrwng
reviewed
Jul 26, 2024
Yes I did, and noted. |
WillemKauf
force-pushed
the
abs_directory_operation_not_supported
branch
from
01ac328
to
436eb45
Compare
andrwng
previously approved these changes
Jul 26, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52066#0190ecac-f2ab-49c2-a912-f46ef6900d9a ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52066#0190ecaf-6dc0-47cc-bfb7-9e9359f58f94 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52104#0190f00b-d231-4df8-9914-8ca1d8493b24 |
Lazin
reviewed
Jul 26, 2024
|
There is a ligging utility that adds rate limiting. This is a serious
configuration error that has to bubble up to the user.
…On Fri, Jul 26, 2024, 16:59 Willem Kaufmann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/v/cloud_storage_clients/abs_client.cc
<#22339 (comment)>
:
> + // doesn't exist. The remote doesn't expect this, so we
+ // map 404s to a successful response.
+ vlog(
+ abs_log.debug,
+ "Object to be deleted was not found in cloud storage: "
+ "object={}, bucket={}. Ignoring ...",
+ name,
+ key);
+ return ss::make_ready_future<ret_t>(no_response{});
+ } else if (
+ result.error() == error_outcome::operation_not_supported) {
+ // ABS does not allow for deletion of directories when HNS
+ // is disabled. The "folder" is "removed" when all blobs
+ // inside of it are deleted. Map this to a successful
+ // response.
+ vlog(
In the case of a mis-match between HNS being enabled in redpanda and in
Blob Storage, I would expect to see this log pop up a lot. I think keeping
it at the debug level might be ideal.
—
Reply to this email directly, view it on GitHub
<#22339 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAWMNVMAK277Z5OXFWCZLLZOJP5TAVCNFSM6AAAAABLPPZD5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBSGA4DIMJRGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
…abs_client::delete_object()` Previously, a `Delete Blob` request made on a directory in ABS would result in an `error_outcome` due to the `OperationNotSupportedOnDirectory` response. We now ignore this outcome instead of propagating an error, and issue a warning log to `abs_log`.
WillemKauf
force-pushed
the
abs_directory_operation_not_supported
branch
from
436eb45
to
744f322
Compare
|
Updated logging severity for unsupported directory delete operation in |
Lazin
approved these changes
Jul 26, 2024
|
/backport v24.2.x |
|
/backport v24.1.x |
|
/backport v23.3.x |
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a
Delete Blobrequest made on a directory in ABS would result in anerror_outcomebeing returned, and propagated outwards due to theOperationNotSupportedOnDirectoryresponse when HNS is not enabled.This would be particularly noisy and harmful when
redpandais not configured for HNS in ABS, while the Azure account is, due to the use ofremote::delete_objects()in various locations in the code.Add the
error_outcome::operation_not_supportedvalue, and ignore this error when encountered withinabs_client::delete_object(). We still make sure to issue a debug log toabs_log.Tested manually on personal ABS account.
Backports Required
Release Notes