Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-4442] schema_registry: Support subjectPrefix for get_subjects #20145

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Jun 26, 2024

Support subjectPrefix for GET /subjects

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Features

  • Schema Registry: Support subjectPrefix for GET /subjects

@BenPope BenPope self-assigned this Jun 26, 2024
@BenPope BenPope added the area/schema-registry Schema Registry service within Redpanda label Jun 26, 2024
Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope force-pushed the schema_registry/subjectPrefix branch from 2ff26f3 to 1b9d26f Compare June 26, 2024 07:03
@BenPope BenPope requested a review from a team as a code owner June 26, 2024 07:03
@BenPope BenPope changed the title schema_registry: Support subjectPrefix for get_subjects [CORE-4442] schema_registry: Support subjectPrefix for get_subjects Jun 26, 2024
@BenPope BenPope requested a review from andijcr June 26, 2024 11:02
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@@ -574,6 +574,12 @@
"in": "query",
"required": false,
"type": "string"
},
{
"name": "subjectPrefix",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a description?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a description?

Probably, but none of the query parameters do, I have a task to improve this.

@BenPope BenPope merged commit e238a47 into redpanda-data:dev Jun 26, 2024
20 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda area/schema-registry Schema Registry service within Redpanda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants