Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha/labeler: fix format of yml file for v5 #19625

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Jun 11, 2024

follow-on to PR #18857

fixes error in Pull Request Labeler / triage (pull_request_target) check:

Error: found unexpected type for label 'area/k8s' (should be array of config options)

The v5 of labeler has breaking change that needs update to the configuration file:
https://github.com/actions/labeler/tree/v5.0.0?tab=readme-ov-file#breaking-changes-in-v5

This fixes it and retains existing behavior. Just syntax differences.

Unfortunately, the gha job triage will fail using label v5 until this PR is merged to dev branch because of known issue actions/labeler#712 (comment), so needs a force merge.

I recommend merging this PR to keep the fixes for nodejs that were brought in with labeler v5. But if this PR is merged, then PR #19626 should not be merged.

jira: https://redpandadata.atlassian.net/browse/PESDLC-1510

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

The v5 of labeler has breaking change that needs update to the
configuration file:
https://github.com/actions/labeler/tree/v5.0.0?tab=readme-ov-file#breaking-changes-in-v5

This fixes it and retains existing behavior. Just syntax differences.
@andrewhsu andrewhsu force-pushed the PESDLC-1510-fix-labeler-format branch 2 times, most recently from c480fff to d2e7e86 Compare June 11, 2024 16:15
@andrewhsu andrewhsu marked this pull request as ready for review June 11, 2024 16:20
@andrewhsu andrewhsu requested a review from a team as a code owner June 11, 2024 16:20
@andrewhsu andrewhsu requested review from ivotron and removed request for a team June 11, 2024 16:20
Copy link
Contributor

@clee clee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link
Member Author

andrewhsu commented Jun 11, 2024

@redpanda-data/core-admin this PR needs forcing merge because the PR job cannot validate the labeler.yml syntax update. known issue with labeler config changes in issue: actions/labeler#712 (comment)

@andrewhsu
Copy link
Member Author

i'm force-merging because i have approval and (temp) permissions

@andrewhsu andrewhsu merged commit 0ca0de7 into dev Jun 11, 2024
11 of 12 checks passed
@andrewhsu andrewhsu deleted the PESDLC-1510-fix-labeler-format branch June 11, 2024 17:00
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants