rpk: display float values as float in cluster config get #18841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 610e3ad we introduced a fix for redpanda-data#6070, to avoid printing large numbers with scientific notation, we treated all numbers as integers. Now, the API uses float values and they are being rounded, this change introduce a mod check to determine whether the number is an integer or a float.
twmb
approved these changes
Jun 6, 2024
|
/backport v24.1.x |
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 610e3ad we introduced a fix for #6070, to avoid printing large numbers with scientific notation, we treated all numbers as integers.
Now, the API uses float values and they are rounded by rpk, this change introduces a mod check to determine whether the number is an integer or a float.
Backports Required
Release Notes
Bug Fixes