rpk/transform: support javascript and typescript #18078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
to be valid json 🤦 Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
rockwotj
force-pushed
the
lto
branch
4 times, most recently
from
9504bf0
to
b272c40
Compare
rockwotj
requested review from
twmb,
r-vasquez,
gene-redpanda,
Deflaimun and
a team
as code owners
rockwotj
requested review from
andrewhsu and
oleiman
and removed request for
a team
r-vasquez
previously approved these changes
Apr 29, 2024
To support JS and TS we need: 1) To generate an NPM project with esbuild and (optional) typescript 2) A new buildpack that has our JS VM and can package that with the source Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
This script will build the binaries that RPK needs when turning JS -> Wasm. The resulting tarballs need to be hosted somewhere (S3?) for RPK to download. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Using this other type of comment allows LSPs to show the docs inline. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Specifically check we can't find the binary, and print the error if it is less expected. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
oleiman
reviewed
Apr 30, 2024
| set_property(TARGET redpanda_js_transform PROPERTY INTERPROCEDURAL_OPTIMIZATION ON) | ||
| endif() | ||
| endif() | ||
| # TODO: Rename LTO builds when #18077 is merged |
There was a problem hiding this comment.
Yes will do in a followup, I would like to get this in for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support JS and TS for Data Transforms.
We still have work to do here, mainly a deploy pipeline for the JS buildpack, otherwise I have proof this is working end to end.
Closes: CORE-2370 and CORE-2373
Backports Required
Release Notes
Features