-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: Added EHOSTUNREACH to retry list #16902
net: Added EHOSTUNREACH to retry list #16902
Conversation
@@ -53,6 +54,7 @@ bool is_reconnect_error(const std::system_error& e) { | |||
case ECONNABORTED: | |||
case EAGAIN: | |||
case EPIPE: | |||
case EHOSTUNREACH: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there are any other error codes we could opportunistically add here? E.g.:
ESHUTDOWN
EHOSTDOWN
ENETRESET
ENETDOWN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ESHUTDOWN
is where we shutdown the socket (https://linux.die.net/man/3/shutdown). So probably an artifact of shutting down and not a retry. Thoughts?
I think the other three can be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably shut down the socket on all manner of alternative errors. At initial glance, I didn't see an abort source which would be more explicit about shutdown.
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45699#018e0f8f-587a-4157-9242-ddbb3fb31f2b ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45699#018e0f8f-5871-4b36-ab9f-1cf578bbc170 |
a111680
to
a6d1670
Compare
Force push
|
new failures in https://buildkite.com/redpanda/redpanda/builds/45755#018e1580-415e-4e34-bab0-4adc2c4a1b87:
new failures in https://buildkite.com/redpanda/redpanda/builds/45975#018e2df2-7481-48f7-9604-2165d4c2644e:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
nit: commit message
Added: - EHOSTUNREACH - EHOSTDOWN - ENETRESET - ENETDOWN Fixes: redpanda-data#16901 Signed-off-by: Michael Boquard <michael@redpanda.com>
a6d1670
to
0f35361
Compare
Force push
|
/backport v23.3.x |
/backport v23.2.x |
@@ -17,6 +17,7 @@ | |||
#include <seastar/core/future.hh> | |||
#include <seastar/net/tls.hh> | |||
|
|||
#include <asm-generic/errno.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm pretty sure you should only need <errno.h>
but the LSP usually doesn't know
Fixes: #16901
Backports Required
Release Notes
Improvements
EHOSTUNREACH
to retry-able error code list