c/leader_balancer: use btree_map as a group to revision index #11706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a system where there is a lot of raft groups using `absl::flat_hash_map` to store mapping from `raft::group_id` to `model::revision_id` might lead to large contiguous allocation. Replaced `flat_hash_map` with `btree_map` as the code is not performance critical. Fixes: redpanda-data#11670 Signed-off-by: Michal Maslanka <michal@redpanda.com>
bharathv
approved these changes
Jun 27, 2023
|
/backport v23.1.x |
This was referenced Jun 27, 2023
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a system where there is a lot of raft groups using
absl::flat_hash_mapto store mapping fromraft::group_idtomodel::revision_idmight lead to large contiguous allocation.Replaced
flat_hash_mapwithbtree_mapas the code is not performance critical.Fixes: #11670
Backports Required
Release Notes