k/proto: use log-level warn for invalid crc #11384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, redpanda-data#11324 changed the log-level from error to warn for a CRC missmatch. However, on the same event, RP will also log "batch has invalid CRC" at the error level. This commit therefore changes the log for "batch has invalid CRC" to warn level. Fixes redpanda-data#11361
michael-redpanda
approved these changes
Jun 13, 2023
|
/backport v23.1.x |
|
/backport v22.3.x |
|
/backport v22.2.x |
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, #11324 changed the log-level from error to warn for a CRC missmatch. However, on the same event, RP will also log "batch has invalid CRC" at the error level.
This PR therefore changes the log for "batch has invalid CRC" to warn level.
Fixes #11361
Backports Required
Release Notes