rpk profile: more #11296
Merged
rpk profile: more #11296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-vasquez
force-pushed
the
rpk-profile-more
branch
from
6aa1dee
to
6f9c31d
Compare
r-vasquez
force-pushed
the
rpk-profile-more
branch
from
6f9c31d
to
2759ae4
Compare
|
Force-push change: ducktape test modification for the |
r-vasquez
force-pushed
the
rpk-profile-more
branch
2 times, most recently
from
04cd087
to
2759ae4
Compare
Comment on lines
+1060
to
1081
| func (c *Config) ensureBrokerAddrs() { | ||
| { | ||
| dst := &c.redpandaYaml | ||
| if len(dst.Rpk.KafkaAPI.Brokers) == 0 { | ||
| dst.Rpk.KafkaAPI.Brokers = []string{net.JoinHostPort("127.0.0.1", strconv.Itoa(DefaultKafkaPort))} | ||
| } | ||
| if len(dst.Rpk.AdminAPI.Addresses) == 0 { | ||
| dst.Rpk.AdminAPI.Addresses = []string{net.JoinHostPort("127.0.0.1", strconv.Itoa(DefaultAdminPort))} | ||
| } | ||
| } | ||
| { | ||
| dst := c.rpkYaml.Profile(c.rpkYaml.CurrentProfile) // must exist by this function | ||
| if len(dst.KafkaAPI.Brokers) == 0 { | ||
| dst.KafkaAPI.Brokers = []string{net.JoinHostPort("127.0.0.1", strconv.Itoa(DefaultKafkaPort))} | ||
| } | ||
| if len(dst.AdminAPI.Addresses) == 0 { | ||
| dst.AdminAPI.Addresses = []string{net.JoinHostPort("127.0.0.1", strconv.Itoa(DefaultAdminPort))} | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // We merge redpanda.yaml's rpk section back into rpk.yaml's profile. This |
There was a problem hiding this comment.
does this do what i think it does? i dont have to add the broker address at the end of brokers anymore? because if so... 🥂
gene-redpanda
previously approved these changes
Jun 9, 2023
Exits without additional formatting, if the input string is already formatted.
This might belong in rpk profile prompt; it's a bit niche.
* clear unsets any current profile * current prints the current profile name
This allows cloning profiles or easily transferring a profile between laptops.
This allows putting `$(rpk profile prompt)` in your PS1
This finally allows for modifying settings of rpk itself. This will be wired through in a future commit.
…stable The stable column is different from the HWM in two cases: 1, and far more common: Records were produced between the HWM and LSO. 2, less common: Transactions are being used. We always requested the stable offset after HWM, so frequently, the stable offset would look higher than the HWM (which is wrong!), and it would actually be equal behind the scenes but only look different due to time. Hiding it by default is less confusing, and requesting the stable offsets second rather than third prevents stable appearing higher.
If $HOME is unset, we will not load nor write an rpk.yaml. Trying to write will fail, but loading will just use defaults or just use values from redpanda.yaml or env or flags.
-v=info by default was confusing and as it turns out, when you want logs, you almost always want debug logs (for now). We can switch back later if need be.
* We always want to show all defaults -- showing everything makes it easier for the user to know what is possible for modify * We always want to show the profile name since it is always useful
This will let user pick an specific profile while running any command. Useful when you want to run the same across multiple profiles.
gene-redpanda
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds some missing features of rpk profile:
--stabletorpk topic describeto only print thestablecolumn if the flag is used.-vchange to default to DEBUG level instead of INFO.brokers,api-urls,admin-api-tls, etc...)--profilethat let users pick profiles while running a single rpk command.Backports Required
Release Notes