raft: reject linearizable_barrier if not is_leader() #10921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test noticed that a Kafka ListOffsets request issued concurrently with raft election could return a commit_index lower than the last message committed on the previous leader. To the client this looks like time travel on their topic's HWM. We could special case this for ListOffsets, but linearizable_barrier is used lots of places, and probably none of them actually want to run in this brief millisecond between leader election and is_leader() becoming true. Fixes redpanda-data#10885
jcsp
force-pushed
the
issue-10885-raft-is-elected
branch
from
fb58463
to
d170fc6
Compare
mmaslankaprv
approved these changes
May 24, 2023
|
/backport v23.1.x |
|
/backport v22.3.x |
|
/backport v22.2.x |
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test noticed that a Kafka ListOffsets request issued concurrently with raft election could return a commit_index lower than the last message committed on the previous leader.
To the client this looks like time travel on their topic's HWM.
We could special case this for ListOffsets, but linearizable_barrier is used lots of places, and probably none of them actually want to run in this brief millisecond between leader election and is_leader() becoming true.
Fixes #10885
Backports Required
Release Notes
Bug Fixes