Add available memory to internal metrics #10018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intended to replace an ss::metrics::metric_groups instance when you want a metric exposed on both the /metrics (aka "internal") and /public_metrics (aka "public") metrics endpoint. Removes the boilerplate needed to add the metrics to both places.
Previously this was only available on /public_metrics, but this has proven problematic. See redpanda-data#9982 for details. Fixes redpanda-data#9982.
travisdowns
changed the title
|
YES! |
ballard26
approved these changes
Apr 13, 2023
|
/backport v23.1.x |
This was referenced Apr 13, 2023
|
Is it ok to backport this to 22.3.x? I was looking for this metric today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the available_memory metric, which has been very useful, to the internal metrics endpoint in addition to the public metrics one (where it is today).
Currently, some users are pulling only /metrics or have dashboards or other integrations oriented towards /metrics, and can't use this key memory metric. Furthermore, all of the other memory metrics are in /metrics so it is odd that the most important memory metric is stranded elsewhere.
This change reverses this decision and put available_memory in both places, in line with all other memory metrics and the majority of metrics in general.
See https://github.com/redpanda-data/core-internal/issues/103 for background on this metric.
Fixes #9982.
Backports Required
Release Notes
Bug Fixes