Merge pull request #9904 from jcsp/issue-9375-trim-indices

storage: shrink index vectors on flush

src/v/storage/index_state.h

@@ -156,6 +156,12 @@ struct index_state
           position_index[i]};
     }
 
+    void shrink_to_fit() {
+        relative_offset_index.shrink_to_fit();
+        relative_time_index.shrink_to_fit();
+        position_index.shrink_to_fit();
+    }
+
     std::optional<std::tuple<uint32_t, offset_time_index, uint64_t>>
     find_entry(model::timestamp ts) {
         const auto idx = offset_time_index{ts, with_offset};

src/v/storage/segment_index.cc

@@ -240,6 +240,12 @@ ss::future<> segment_index::flush() {
     }
     _needs_persistence = false;
     clear_cached_disk_usage();
+
+    // Flush is usually called when we either shrunk the index (truncate)
+    // or when we're no longer going to append (close): in either case,
+    // it is a good time to free speculatively allocated memory.
+    _state.shrink_to_fit();
+
     return with_file(open(), [this](ss::file backing_file) {
         return flush_to_file(std::move(backing_file));
     });