Skip to content

Commit

Permalink
cloud_storage/tests: start remote instances
Browse files Browse the repository at this point in the history
Previously this was being instantiated and stopped, but
never started.  That results in segment/reader eviction
not happening, now that `remote` contains the `materialized_segments`
state.
  • Loading branch information
jcsp committed Nov 3, 2022
1 parent 3f06c4a commit 0c21989
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/v/cloud_storage/tests/remote_partition_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ static model::record_batch_header read_single_batch_from_remote_partition(
auto conf = fixture.get_configuration();
static auto bucket = s3::bucket_name("bucket");
remote api(s3_connection_limit(10), conf, config_file);
api.start().get();
auto action = ss::defer([&api] { api.stop().get(); });
auto m = ss::make_lw_shared<cloud_storage::partition_manifest>(
manifest_ntp, manifest_revision);
Expand Down Expand Up @@ -438,6 +439,7 @@ static std::vector<model::record_batch_header> scan_remote_partition(
auto conf = imposter.get_configuration();
static auto bucket = s3::bucket_name("bucket");
remote api(s3_connection_limit(10), conf, config_file);
api.start().get();
auto action = ss::defer([&api] { api.stop().get(); });
auto m = ss::make_lw_shared<cloud_storage::partition_manifest>(
manifest_ntp, manifest_revision);
Expand Down Expand Up @@ -967,6 +969,7 @@ scan_remote_partition_incrementally(
auto conf = imposter.get_configuration();
static auto bucket = s3::bucket_name("bucket");
remote api(s3_connection_limit(10), conf, config_file);
api.start().get();
auto action = ss::defer([&api] { api.stop().get(); });
auto m = ss::make_lw_shared<cloud_storage::partition_manifest>(
manifest_ntp, manifest_revision);
Expand Down Expand Up @@ -1088,6 +1091,7 @@ FIXTURE_TEST(test_remote_partition_read_cached_index, cloud_storage_fixture) {
auto conf = get_configuration();
auto bucket = s3::bucket_name("bucket");
remote api(s3_connection_limit(10), conf, config_file);
api.start().get();
auto action = ss::defer([&api] { api.stop().get(); });
auto m = ss::make_lw_shared<cloud_storage::partition_manifest>(
manifest_ntp, manifest_revision);
Expand Down

0 comments on commit 0c21989

Please sign in to comment.