Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a twine check prior to package release #3198

Merged
merged 1 commit into from
May 5, 2024

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Apr 2, 2024

Twine supports a basic check for the package prior to upload. Prior to this the package was built and installed via a different CI.

It is theoretically possible for the associated tools (or a python version) to create broken packages, in between the initial pull request, and an actual release. This at least adds a basic safety check.

@chayim
Copy link
Contributor Author

chayim commented Apr 2, 2024

@dvora-h surprise

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.41%. Comparing base (2f88840) to head (4e017f4).
Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3198       +/-   ##
===========================================
- Coverage   91.84%   70.41%   -21.44%     
===========================================
  Files         128      128               
  Lines       33232    33287       +55     
===========================================
- Hits        30523    23440     -7083     
- Misses       2709     9847     +7138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvora-h
Copy link
Collaborator

dvora-h commented Apr 8, 2024

@chayim Nice to see you here :)

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Apr 8, 2024
@dvora-h dvora-h merged commit 64f291f into redis:master May 5, 2024
46 of 47 checks passed
gerzse pushed a commit to gerzse/redis-py that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants